cstamas commented on pull request #548: URL: https://github.com/apache/maven/pull/548#issuecomment-925169504
Also, just a remark: "I'm not sure if there's much difference between using the PlexusContainer api or the Sisu one". There are, a lot. If you consider, Plexus Container API (let's call it pc-api), we have two implementations: pc-shim (implemented using Sisu) and pc-default (the oldie/original p-c-d, still in use in some places!). So pc-shim provides API compatible (more or less) implementation of pc-api, ON TOP of Sisu. Also, it "bridges" the two worlds, so Plexus component can be injected into JSR330 component, and other way around, JSR330 component can be injected into Plexus component (as `@Requirement`). As Maven Core got moved to JSR330 (except maven-compat, that is to be dropped anyway), we have mainly JSR330 components. So, Plexus "universe" should be considered more as a "legacy", as less and less (in core nada, and in surrounding dependencies we work on killing them off) Plexus component will come into play. So to say, Plexus component count is falling, while JSR330 component count is growing. Given this above, and the fact that (legacy) Plexus components are "equal citizens" compared to JSR330 components, I see it awkward to use pc-api to manipulate something that (most probably) comes (or will come once we process all dependencies) as JSR330 component. So, this is why I consider pc-api something to avoid, if possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
