arturobernalg commented on a change in pull request #8:
URL:
https://github.com/apache/maven-resolver-ant-tasks/pull/8#discussion_r720788984
##########
File path: src/main/java/org/apache/maven/resolver/internal/ant/AntRepoSys.java
##########
@@ -649,11 +649,10 @@ private Properties getEnvProperties( Properties props )
{
props = new Properties();
}
- boolean envCaseInsensitive = OS_WINDOWS;
for ( Map.Entry<String, String> entry : System.getenv().entrySet() )
{
String key = entry.getKey();
- if ( envCaseInsensitive )
+ if ( OS_WINDOWS )
Review comment:
> But previously the code would suggest we are interested in environment
being or not case insensitive. But now it's only about being Windows. I think
the readability is lowered now.
Created a variable and don't use it make the code more complex and harder to
follow. If the idea is modify the variable in the middle, should be do, but
in the midtime, cause noise instead of help. of course that IMO.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
