khmarbaise commented on a change in pull request #9:
URL:
https://github.com/apache/maven-resolver-ant-tasks/pull/9#discussion_r720815728
##########
File path: src/main/java/org/apache/maven/resolver/internal/ant/AntRepoSys.java
##########
@@ -821,17 +821,13 @@ private void populateCollectRequest( CollectRequest
collectRequest, Task task, R
{
continue;
}
- Dependency dependency = new Dependency();
+ final Dependency dependency = new Dependency();
dependency.setCoords( line );
dependencies.add( dependency );
}
}
- finally
- {
- reader.close();
- }
}
- catch ( IOException e )
+ catch ( final IOException e )
Review comment:
That's simply not related and shouldn't being done with the same issue.
I would suggest to focus on the subject of the issue...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
