[ 
https://issues.apache.org/jira/browse/MNG-6762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17424938#comment-17424938
 ] 

Michael Osipov commented on MNG-6762:
-------------------------------------

[~anatoly.zaretsky], [I have expressed my opinion on this approach on the 
PR|https://github.com/apache/maven/pull/566#issuecomment-935664734] why it is 
wrong and why it must be consistent with the default behavior. Namely, 
{{maven.config}} contains line-by-line CLI args which must be evaluated 
identically. Same applies to {{jvm.config}}, it is identical to {{MAVEN_OPTS}}. 
It was an error from begin with not to expand {{maven.config}} just like 
{{jvm.config}}.

Though, I need to check {{-f}} *does not* imply a {{chdir()}}.

> Multimodule project with .mvn/settings.xml not working properly
> ---------------------------------------------------------------
>
>                 Key: MNG-6762
>                 URL: https://issues.apache.org/jira/browse/MNG-6762
>             Project: Maven
>          Issue Type: Improvement
>    Affects Versions: 3.5.4
>            Reporter: Morten Minke
>            Priority: Minor
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> I have a project with the following setup:
>  
> {noformat}
> - MyProject
>   |- .mvn
>   |  |- maven.config
>   |  |- settings.xml
>   |- MyModule1
>   |  |- pom.xml
>   |- MyModule2
>   |  |- pom.xml
>   |- pom.xml{noformat}
>  
> The .mvn/maven.config file contains the following:
> {noformat}
> ..
> --settings .mvn/settings.xml{noformat}
> With this setup, I cannot build the modules separately because it cannot find 
> the .mvn/settings.xml file in the MyModule1 directory.
>  
> I looked into the code and saw that in the mvn script, the .mvn folder is 
> searched for in the parent folders. If it is found, that folder is marked as 
> the 'maven.multiModuleProjectDirectory'.
>  
> However, as soon as the configuration is loaded, this 
> multiModuleProjectDirectory is not used anymore for the interpretation of the 
> --settings property, therefor maven tries to find the .mvn/settings.xml file 
> inside the MyModule1 folder where it is not found.
> This results in an Exception and termination of Maven.
>  
> I thought of a couple of ways this could be solved:
>  * Allow for a variable substitution to work in the maven.config file and 
> thus reference something like:
> {noformat}
> ..
> --settings ${baseDir}/.mvn/settings.xml{noformat}
>  * When the maven.multiModuleProjectDirectory is configured and the 
> --settings flag is a relative directory, than use the 
> maven.multiModuleProjectDirectory as the root to obtain the settings.xml file.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to