rmannibucau commented on a change in pull request #125:
URL: https://github.com/apache/maven-resolver/pull/125#discussion_r723880468
##########
File path:
maven-resolver-api/src/main/java/org/eclipse/aether/DefaultSessionData.java
##########
@@ -81,4 +82,8 @@ public Object get( Object key )
return data.get( key );
}
+ public Object computeIfAbsent( Object key, Function<Object, Object>
mappingFunction )
Review comment:
it is also true it could be a supplier since the key is in the signature
as well or an unaryoperator which is a fn a->a. We don't have to align on the
underlying impl (map) but the nice thing with a fn is that, when the computing
depends on the key you don't need to pass it each time and can reuse a method
ref. An unaryoperator being a function, the signature complies to it so overall
I think it is a good one @cstamas .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
