cstamas commented on pull request #580: URL: https://github.com/apache/maven/pull/580#issuecomment-940898997
Just some thoughts popping out here: > they have exactly the same lifecycle, because they contain a (intended) hard version of Maven Why? I mean, isn't (some future) script of 4.0.1 and 4.0.2 99.9% identical, sans the "hard version"? So we redeploy same scripts over and over just to have "hard version" in them? What if it turns out that 4.0.1 script has a bug, how to fix it? As redeploying 4.0.3 will NOT fix the script for 4.0.1. > Also, the mvnw is about 80% the same as mvn and improvements on one should also be part of the other. Isn't that a sign that mvn script itself needs to be pulled out of apache-maven project than? And then that pulled out artifact can be shared across projects, like apache-maven and wrapper is? After all, if you not count @michael-o fixes, they also were pretty much "static" (unchanged), no? ---- IMHO, even the current https://github.com/apache/maven-wrapper-plugin plugin goes like this: 1. user invokes `mvn wrapper:wrapper` 2. Maven resolves LATEST, executes it 3. plugin takes _Maven version_ that runs the plugin 4. "inject wrapper into project" --> currently NOT, as it insist on Maven4 So, IMO, much simpler would be IF: maven-wrapper-plugin "knows" about the Maven versions (it means "close" but not same "release cadence") as with example above (4.0.1 script buggy), we can release maven-wrapper-plugin 1.0.0 then 1.0.1 with fixed scripts, and voila! Users automagically pick up the fixed scripts. Unsure why Takari had wrapper-maven-plugin -> maven-wrapper -> maven indirection in place, but in our case (Maven is "smart" as plugin is o.a.m.p groupId), it is simplest to have everything in maven-wrapper-plugin And both, maven-wrapper-plugin and apache-maven use _pulled out scripts_ from some new artifact. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
