cstamas opened a new pull request #132: URL: https://github.com/apache/maven-resolver/pull/132
Drop the hoops and loops, sort out everything in name mapper (resolution against session baseDir) instead doing path->string->path translations in mapper then in FS lock factory. Notable changes: * make FileLockNamedLockFactory non-abstract, move it providers * add "fs friendly" marker iface and make Selector enforce it: if lock factory is FS friendlly, name mapper must be as well * drop hackish SessionAwareNamedLockFactory iface, as NameMapper is able to sort out everything (resolution against session basedir): consequence is that we do NOT do string -> path -> string -> path conversions anymore, as "name" is a full abs path. Another consequence: adapter hackish smell is gone as well. * TakariNameMapper had session all the time, but it was not using it: now it uses it and produces absolute paths resolved against session basedir, and is marked as "fs friendly". * these changes allows future use of other than TakariNameMapper (ie. 3rd party), all is needed is to be properly marked. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
