[ 
https://issues.apache.org/jira/browse/MJAVADOC-681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17434708#comment-17434708
 ] 

Pavel Varchenko edited comment on MJAVADOC-681 at 10/27/21, 7:55 AM:
---------------------------------------------------------------------

It is strange, but looks like the fix did not help.

All is ok with index.html now, but the hash for javadoc.jar still different for 
each build

 
{code:java}
 ➜  reproducible-build git:(master) ✗ diffoscope 
target/reproducible-build-1.0-SNAPSHOT-javadoc.jar 
target/ref/reproducible-build-1.0-SNAPSHOT-javadoc.jar
--- target/reproducible-build-1.0-SNAPSHOT-javadoc.jar
+++ target/ref/reproducible-build-1.0-SNAPSHOT-javadoc.jar
├── zipinfo -v {}
│ @@ -1437,15 +1437,15 @@
│    minimum file system compatibility required:     MS-DOS, OS/2 or NT FAT
│    minimum software version required to extract:   2.0
│    compression method:                             deflated
│    compression sub-type (deflation):               normal
│    file security status:                           not encrypted
│    extended local header:                          no
│    file last modified on (DOS date/time):          1980 000 0 04:08:00
│ -  32-bit CRC value (hex):                         16f7df7c
│ +  32-bit CRC value (hex):                         8e7799f9
│    compressed size:                                145 bytes
│    uncompressed size:                              216 bytes
│    length of filename:                             23 characters
│    length of extra field:                          0 bytes
│    length of file comment:                         0 characters
│    disk number on which file begins:               disk 1
│    apparent file type:                             binary
│ @@ -1524,15 +1524,15 @@
│    minimum file system compatibility required:     MS-DOS, OS/2 or NT FAT
│    minimum software version required to extract:   2.0
│    compression method:                             deflated
│    compression sub-type (deflation):               normal
│    file security status:                           not encrypted
│    extended local header:                          no
│    file last modified on (DOS date/time):          1980 000 0 04:08:00
│ -  32-bit CRC value (hex):                         fdf95731
│ +  32-bit CRC value (hex):                         47a631ce
│    compressed size:                                139 bytes
│    uncompressed size:                              211 bytes
│    length of filename:                             24 characters
│    length of extra field:                          0 bytes
│    length of file comment:                         0 characters
│    disk number on which file begins:               disk 1
│    apparent file type:                             binary
│ @@ -1814,15 +1814,15 @@
│    minimum file system compatibility required:     MS-DOS, OS/2 or NT FAT
│    minimum software version required to extract:   2.0
│    compression method:                             deflated
│    compression sub-type (deflation):               normal
│    file security status:                           not encrypted
│    extended local header:                          no
│    file last modified on (DOS date/time):          1980 000 0 04:08:00
│ -  32-bit CRC value (hex):                         ef971745
│ +  32-bit CRC value (hex):                         7e0db286
│    compressed size:                                162 bytes
│    uncompressed size:                              230 bytes
│    length of filename:                             21 characters
│    length of extra field:                          0 bytes
│    length of file comment:                         0 characters
│    disk number on which file begins:               disk 1
│    apparent file type:                             binary
├── member-search-index.zip
│┄ Archive contents identical but files differ, possibly due to different 
compression levels. Falling back to binary comparison.
│ ├── zipinfo {}
│ │ @@ -1,3 +1,3 @@
│ │  Zip file size: 216 bytes, number of entries: 1
│ │ --rw----     2.0 fat       66 bl defN 21-Oct-27 10:52 
member-search-index.json
│ │ +-rw----     2.0 fat       66 bl defN 21-Oct-27 10:38 
member-search-index.json
│ │  1 file, 66 bytes uncompressed, 54 bytes compressed:  18.2%
│ ├── member-search-index.zip
│ │ @@ -1,14 +1,14 @@
│ │ -00000000: 504b 0304 1400 0808 0800 9956 5b53 0000  PK.........V[S..
│ │ +00000000: 504b 0304 1400 0808 0800 cf54 5b53 0000  PK.........T[S..
│ │  00000010: 0000 0000 0000 0000 0000 1800 0000 6d65  ..............me
│ │  00000020: 6d62 6572 2d73 6561 7263 682d 696e 6465  mber-search-inde
│ │  00000030: 782e 6a73 6f6e 8bae 562a 50b2 52b2 09cd  x.json..V*P.R...
│ │  00000040: cb4b cc4d 4db1 53d2 514a 06f2 3d52 7372  .K.MM.S.QJ..=Rsr
│ │  00000050: f281 ec1c 185b 4313 c82b 2d02 f155 8d9d  .....[C..+-..U..
│ │  00000060: 33f3 324b 548d 5d81 82b5 b100 504b 0708  3.2KT.].....PK..
│ │  00000070: 9709 abfd 3600 0000 4200 0000 504b 0102  ....6...B...PK..
│ │ -00000080: 1400 1400 0808 0800 9956 5b53 9709 abfd  .........V[S....
│ │ +00000080: 1400 1400 0808 0800 cf54 5b53 9709 abfd  .........T[S....
│ │  00000090: 3600 0000 4200 0000 1800 0000 0000 0000  6...B...........
│ │  000000a0: 0000 0000 0000 0000 0000 6d65 6d62 6572  ..........member
│ │  000000b0: 2d73 6561 7263 682d 696e 6465 782e 6a73  -search-index.js
│ │  000000c0: 6f6e 504b 0506 0000 0000 0100 0100 4600  onPK..........F.
│ │  000000d0: 0000 7c00 0000 0000                      ..|.....
├── package-search-index.zip
│┄ Archive contents identical but files differ, possibly due to different 
compression levels. Falling back to binary comparison.
│ ├── zipinfo {}
│ │ @@ -1,3 +1,3 @@
│ │  Zip file size: 211 bytes, number of entries: 1
│ │ --rw----     2.0 fat       53 bl defN 21-Oct-27 10:52 
package-search-index.json
│ │ +-rw----     2.0 fat       53 bl defN 21-Oct-27 10:38 
package-search-index.json
│ │  1 file, 53 bytes uncompressed, 47 bytes compressed:  11.3%
│ ├── package-search-index.zip
│ │ @@ -1,14 +1,14 @@
│ │ -00000000: 504b 0304 1400 0808 0800 9956 5b53 0000  PK.........V[S..
│ │ +00000000: 504b 0304 1400 0808 0800 cf54 5b53 0000  PK.........T[S..
│ │  00000010: 0000 0000 0000 0000 0000 1900 0000 7061  ..............pa
│ │  00000020: 636b 6167 652d 7365 6172 6368 2d69 6e64  ckage-search-ind
│ │  00000030: 6578 2e6a 736f 6e8b ae56 ca51 b252 72cc  ex.json..V.Q.Rr.
│ │  00000040: c951 0848 4cce 4e4c 4f2d 56d2 512a 2d02  .Q.HL.NLO-V.Q*-.
│ │  00000050: 0926 e6e4 1440 c574 33f3 5252 2bf4 324a  .&[email protected]+.2J
│ │  00000060: 7273 946a 6301 504b 0708 f23a d2a4 2f00  rs.jc.PK...:../.
│ │  00000070: 0000 3500 0000 504b 0102 1400 1400 0808  ..5...PK........
│ │ -00000080: 0800 9956 5b53 f23a d2a4 2f00 0000 3500  ...V[S.:../...5.
│ │ +00000080: 0800 cf54 5b53 f23a d2a4 2f00 0000 3500  ...T[S.:../...5.
│ │  00000090: 0000 1900 0000 0000 0000 0000 0000 0000  ................
│ │  000000a0: 0000 0000 7061 636b 6167 652d 7365 6172  ....package-sear
│ │  000000b0: 6368 2d69 6e64 6578 2e6a 736f 6e50 4b05  ch-index.jsonPK.
│ │  000000c0: 0600 0000 0001 0001 0047 0000 0076 0000  .........G...v..
│ │  000000d0: 0000 00                                  ...
├── type-search-index.zip
│┄ Archive contents identical but files differ, possibly due to different 
compression levels. Falling back to binary comparison.
│ ├── zipinfo {}
│ │ @@ -1,3 +1,3 @@
│ │  Zip file size: 230 bytes, number of entries: 1
│ │ --rw----     2.0 fat       81 bl defN 21-Oct-27 10:52 type-search-index.json
│ │ +-rw----     2.0 fat       81 bl defN 21-Oct-27 10:38 type-search-index.json
│ │  1 file, 81 bytes uncompressed, 72 bytes compressed:  11.1%
│ ├── type-search-index.zip
│ │ @@ -1,15 +1,15 @@
│ │ -00000000: 504b 0304 1400 0808 0800 9956 5b53 0000  PK.........V[S..
│ │ +00000000: 504b 0304 1400 0808 0800 cf54 5b53 0000  PK.........T[S..
│ │  00000010: 0000 0000 0000 0000 0000 1600 0000 7479  ..............ty
│ │  00000020: 7065 2d73 6561 7263 682d 696e 6465 782e  pe-search-index.
│ │  00000030: 6a73 6f6e 8bae 56ca 51b2 5272 ccc9 5170  json..V.Q.Rr..Qp
│ │  00000040: ce49 2c2e 4e2d 56d2 512a 2d02 8925 e6e4  .I,.N-V.Q*-..%..
│ │  00000050: 2443 8474 33f3 5252 2bf4 324a 7273 946a  $C.t3.RR+.2Jrs.j
│ │  00000060: 75aa 950a 80b2 36a1 7979 89b9 a929 7640  u.....6.yy...)v@
│ │  00000070: f520 d51e a939 39f9 4ab5 b100 504b 0708  . ...99.J...PK..
│ │  00000080: b126 8f73 4800 0000 5100 0000 504b 0102  .&.sH...Q...PK..
│ │ -00000090: 1400 1400 0808 0800 9956 5b53 b126 8f73  .........V[S.&.s
│ │ +00000090: 1400 1400 0808 0800 cf54 5b53 b126 8f73  .........T[S.&.s
│ │  000000a0: 4800 0000 5100 0000 1600 0000 0000 0000  H...Q...........
│ │  000000b0: 0000 0000 0000 0000 0000 7479 7065 2d73  ..........type-s
│ │  000000c0: 6561 7263 682d 696e 6465 782e 6a73 6f6e  earch-index.json
│ │  000000d0: 504b 0506 0000 0000 0100 0100 4400 0000  PK..........D...
│ │  000000e0: 8c00 0000 0000     
{code}
 

 


was (Author: varpa89):
It is strange, but looks like the fix did not help.

All is ok with index.html now, but the hash for javadoc.jar still different for 
each build

> Reproducible build does not work for maven-javadoc-plugin
> ---------------------------------------------------------
>
>                 Key: MJAVADOC-681
>                 URL: https://issues.apache.org/jira/browse/MJAVADOC-681
>             Project: Maven Javadoc Plugin
>          Issue Type: Bug
>            Reporter: Pavel Varchenko
>            Assignee: Robert Scholte
>            Priority: Major
>
> I've created a project for reproducible build from this guide
> [https://maven.apache.org/guides/mini/guide-reproducible-builds.html]
> Plugins:
> * maven-jar-plugin 3.2.0
> * maven-javadoc-plugin 3.3.0
> * maven-source-plugin 3.2.1
>  
> This project has only one class
> {code}
> /**
>  * Hello
>  */
> public class Hello {
> }
> {code}
>  
> Then I check buildinfo via
> bq. ./mvnw clean verify -e -DskipTests artifact:buildinfo 
> -Dbuildinfo.ignoreJavadoc=false
>  
> sha512 is always the same for reproducible-build-1.0-SNAPSHOT.jar and 
> reproducible-build-1.0-SNAPSHOT-sources.jar
> But for reproducible-build-1.0-SNAPSHOT-javadoc.jar it changes after each 
> build
>  
> Here is the example
> [https://github.com/varpa89/reproducible-build]
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to