michael-o commented on a change in pull request #605:
URL: https://github.com/apache/maven/pull/605#discussion_r742039756
##########
File path: maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java
##########
@@ -1759,27 +1757,8 @@ static void populateProperties( CommandLine commandLine,
Properties systemProper
systemProperties.setProperty( "maven.build.version", mavenBuildVersion
);
}
- private static void setCliProperty( String property, Properties properties
)
+ private static void setCliProperty( String name, String value, Properties
properties )
{
- String name;
-
- String value;
-
- int i = property.indexOf( '=' );
-
- if ( i <= 0 )
- {
- name = property.trim();
-
- value = "true";
- }
- else
- {
- name = property.substring( 0, i ).trim();
-
- value = property.substring( i + 1 );
- }
-
properties.setProperty( name, value );
Review comment:
Right, I have discussed this with @rfscholte. This will go away in
4.0.0. Keep as-is for now.
##########
File path: maven-embedder/src/test/java/org/apache/maven/cli/CLIManagerTest.java
##########
@@ -43,8 +43,10 @@ public void spacedOptions()
{
CommandLine cmdLine = cliManager.parse( "-X -Dx=1 -D y=2 test".split(
" " ) );
Review comment:
I would say yes for consistency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
