AlexanderAshitkin commented on a change in pull request #609:
URL: https://github.com/apache/maven/pull/609#discussion_r747727935
##########
File path:
maven-core/src/main/java/org/apache/maven/lifecycle/internal/MojoExecutor.java
##########
@@ -135,21 +139,26 @@ else if ( Artifact.SCOPE_TEST.equals( classpath ) )
return Collections.unmodifiableCollection( scopes );
}
- public void execute( MavenSession session, List<MojoExecution>
mojoExecutions, ProjectIndex projectIndex )
- throws LifecycleExecutionException
+ public void execute( final MavenSession session,
+ List<MojoExecution> mojoExecutions,
+ final ProjectIndex projectIndex ) throws
LifecycleExecutionException
{
- DependencyContext dependencyContext = newDependencyContext( session,
mojoExecutions );
+ final DependencyContext dependencyContext = newDependencyContext(
session, mojoExecutions );
- PhaseRecorder phaseRecorder = new PhaseRecorder(
session.getCurrentProject() );
+ final PhaseRecorder phaseRecorder = new PhaseRecorder(
session.getCurrentProject() );
- for ( MojoExecution mojoExecution : mojoExecutions )
+ mojoExecutionStrategy.execute( session, mojoExecutions, new
MojoExecutionStrategy.Executor( )
{
- execute( session, mojoExecution, projectIndex, dependencyContext,
phaseRecorder );
- }
+ @Override
+ public void execute( MojoExecution mojoExecution ) throws
LifecycleExecutionException
+ {
+ MojoExecutor.this.execute( session, mojoExecution,
projectIndex, dependencyContext, phaseRecorder );
+ }
+ } );
}
- public void execute( MavenSession session, MojoExecution mojoExecution,
ProjectIndex projectIndex,
+ private void execute( MavenSession session, MojoExecution mojoExecution,
ProjectIndex projectIndex,
Review comment:
this class is not a part of public api - but if someone used it in
extension this is potentially breaking. will be good to no - good or not to go
with visibility change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
