pzygielo edited a comment on pull request #169:
URL: 
https://github.com/apache/maven-dependency-plugin/pull/169#issuecomment-968255529


   > When we have default value, like:
   > 
   > ```
   >  @Parameter( defaultValue = "pom,ear" )
   >  private List<String> ignoredPackagings = new ArrayList<>();
   > ```
   > 
   > In maven `3.2.5` this default value is used always and win with 
configuration for collection in pom.
   > 
   > fixed to:
   > 
   > ```
   > @Parameter
   > private List<String> ignoredPackagings = Arrays.asList( "pom", "ear" );
   > ```
   
   But `defaultValue` finds its way into documentation, in standard way. With 
above (fixed to) approach I would definitely have missed that one sentence of 
description, when looking for defaults only. And maven 3.2.5 looks like very, 
very old version to support its bugs here.
   
   Also the doc formatting is a bit off now (at least sentence could start with 
capital) :
   
![analyze](https://user-images.githubusercontent.com/11896137/141676713-9b0d4458-d604-479f-a881-309e35c5e615.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to