timtebeek commented on a change in pull request #113:
URL: https://github.com/apache/maven-enforcer/pull/113#discussion_r749221460
##########
File path: pom.xml
##########
@@ -122,16 +122,35 @@
<version>3.4.1</version>
</dependency>
<dependency>
- <groupId>junit</groupId>
- <artifactId>junit</artifactId>
- <version>4.13.2</version>
+ <groupId>org.junit.jupiter</groupId>
+ <artifactId>junit-jupiter-api</artifactId>
+ <version>5.8.1</version>
+ <scope>test</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.junit.jupiter</groupId>
+ <artifactId>junit-jupiter-engine</artifactId>
+ <version>5.8.1</version>
+ <scope>test</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.junit.vintage</groupId>
+ <artifactId>junit-vintage-engine</artifactId>
Review comment:
When left out there's a number of tests that fail or error, since
`org.codehaus.plexus.PlexusTestCase` extends `junit.framework.TestCase`.
```
java.lang.NoClassDefFoundError: junit/framework/TestCase
at java.lang.ClassLoader.defineClass1(Native Method)
at java.lang.ClassLoader.defineClass(ClassLoader.java:756)
at
java.security.SecureClassLoader.defineClass(SecureClassLoader.java:142)
at java.net.URLClassLoader.defineClass(URLClassLoader.java:468)
at java.net.URLClassLoader.access$100(URLClassLoader.java:74)
at java.net.URLClassLoader$1.run(URLClassLoader.java:369)
at java.net.URLClassLoader$1.run(URLClassLoader.java:363)
at java.security.AccessController.doPrivileged(Native Method)
at java.net.URLClassLoader.findClass(URLClassLoader.java:362)
at java.lang.ClassLoader.loadClass(ClassLoader.java:418)
at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:352)
at java.lang.ClassLoader.loadClass(ClassLoader.java:351)
at
org.apache.maven.plugins.enforcer.MockProject.getBasedir(MockProject.java:351)
at
org.apache.maven.plugin.PluginParameterExpressionEvaluator.<init>(PluginParameterExpressionEvaluator.java:102)
at
org.apache.maven.plugins.enforcer.EnforcerTestUtils.getHelper(EnforcerTestUtils.java:135)
at
org.apache.maven.plugins.enforcer.EnforcerTestUtils.getHelper(EnforcerTestUtils.java:113)
at
org.apache.maven.plugins.enforcer.TestEvaluateBeanshell.testRulePass(TestEvaluateBeanshell.java:69)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
