Tibor17 commented on a change in pull request #393:
URL: https://github.com/apache/maven-surefire/pull/393#discussion_r749697086



##########
File path: 
maven-surefire-common/src/main/java/org/apache/maven/surefire/providerapi/ServiceLoader.java
##########
@@ -42,7 +45,8 @@
  *
  * @since 2.20
  */
-public final class ServiceLoader
+@Component( role = ServiceLoader.class )
+public class ServiceLoader

Review comment:
       @slawekjaranowski Can this Component be also `public final` class as the 
other classes in this package? So that we indicate that the component class 
cannot be extended by the user in another project.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to