gnodet commented on pull request #618: URL: https://github.com/apache/maven/pull/618#issuecomment-979027091
> > @gnodet no difference should be the target but guess it can be a build time metadata of sisu instead of a runtime annotation - or we do it by reflection and provide it in the bundle, but by the past we got a lot of troubles leaking internal IoC details so hope we don't go back there - not blaming, I know where you went from, just explaining the reasoning. > > No problem with this idea, however anything we may need internally for maven may also be needed by users. I'd rather avoid relying on non supported apis, so maybe we could rely on `javax.annotation.Priority` which seems to be supported by Guice. But we have the same problem and Guice need to see the same class. Using `java.annotation.Priority` works because this package is already exported by maven-core, thus Sisu/Guice has visibility on this annotation inside extensions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
