gnodet commented on pull request #617: URL: https://github.com/apache/maven/pull/617#issuecomment-979417763
> > > > I believe that this entire code needs to be rewritten to use Wagon instead of manually fiddling with `HttpClient`. > > > > > > > > > good point and should not be a big deal. will try to do it in following prs > > > > > > Not necessarily instead, but a simple abstraction layer would allow to use the default http repository or use wagon as an alternative and more versatile provider. > > Agree. It could be reworked as we like in the future, just at this point it will be a small cleanup which doesnt have much of implications. also, it was tested, so it will be great to merge it. > > Conceptually i agree with more comprehensive rework in future I'm going to merge. What's the reasoning for using an `Optional ` instead of throwing an exception ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
