cstamas commented on a change in pull request #15:
URL:
https://github.com/apache/maven-install-plugin/pull/15#discussion_r766053141
##########
File path: src/main/java/org/apache/maven/plugins/install/InstallMojo.java
##########
@@ -94,50 +89,70 @@ public void execute()
boolean addedInstallRequest = false;
if ( skip )
{
+ getPluginContext().put( INSTALL_PROCESSED_MARKER, Boolean.FALSE );
getLog().info( "Skipping artifact installation" );
}
else
{
- // CHECKSTYLE_OFF: LineLength
- ProjectInstallerRequest projectInstallerRequest =
- new ProjectInstallerRequest().setProject( project );
- // CHECKSTYLE_ON: LineLength
-
if ( !installAtEnd )
{
- installProject( session.getProjectBuildingRequest(),
projectInstallerRequest );
+ installProject( project );
}
else
{
- INSTALLREQUESTS.add( projectInstallerRequest );
+ getPluginContext().put( INSTALL_PROCESSED_MARKER, Boolean.TRUE
);
addedInstallRequest = true;
}
}
- boolean projectsReady = READYPROJECTSCOUNTER.incrementAndGet() ==
reactorProjects.size();
- if ( projectsReady )
+ if ( allProjectsMarked() )
Review comment:
If m-install-p is not present, will not, but all "standard" life-cycle
has them. But true, if no m-install-p not present, will not work. Was thinking
about `org.apache.maven.execution.MavenSession#getResult` (and use
`org.apache.maven.execution.MavenExecutionResult#getBuildSummary` to check "is
it done"), wdyt?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
