kwin commented on a change in pull request #38:
URL: https://github.com/apache/maven-plugin-tools/pull/38#discussion_r770767018



##########
File path: 
maven-plugin-plugin/src/main/java/org/apache/maven/plugin/plugin/AbstractGeneratorMojo.java
##########
@@ -294,6 +313,26 @@ static String getDefaultGoalPrefix( MavenProject project )
         return defaultGoalPrefix;
     }
 
+    /**
+     * Collects all dependencies having {@code org.apache.maven} group ID that 
are NOT in provided scope.
+     */
+    private Set<Artifact> mavenDependenciesNotInProvidedScope()
+    {
+        LinkedHashSet<Artifact> wrongScopedDependencies = new 
LinkedHashSet<>();
+
+        for ( Artifact dependency : project.getArtifacts() )
+        {
+            if ( "org.apache.maven".equals( dependency.getGroupId() )

Review comment:
       This leads to false positives: 
https://issues.apache.org/jira/browse/MPLUGIN-385?focusedCommentId=17460907&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17460907




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to