gnodet commented on a change in pull request #6:
URL: https://github.com/apache/maven-clean-plugin/pull/6#discussion_r771988769



##########
File path: src/main/java/org/apache/maven/plugins/clean/CleanMojo.java
##########
@@ -161,6 +162,35 @@
     @Parameter( property = "maven.clean.excludeDefaultDirectories", 
defaultValue = "false" )
     private boolean excludeDefaultDirectories;
 
+    /**
+     * Enables fast clean if possible. If set to <code>true</code>, when the 
plugin is executed, a directory to
+     * be deleted will be atomically moved inside the 
<code>maven.clean.fastDir</code> directory and a thread will
+     * be launched to delete the needed files in the background.  When the 
build is completed, maven will wait
+     * until all the files have been deleted.  If any problem occurs during 
the atomic move of the directories,
+     * the plugin will default to the traditional deletion mechanism.
+     *
+     * @since 3.2
+     */
+    @Parameter( property = "maven.clean.fast", defaultValue = "false" )
+    private boolean fast;
+
+    /**
+     * When fast clean is specified, the <code>fastDir</code> property will be 
used as the location where directories
+     * to be deleted will be moved prior to background deletion.  If not 
specified, the
+     * <code>${maven.multiModuleProjectDirectory}/target/.clean</code> 
directory will be used.  If the
+     * <code>${build.directory}</code> has been modified, you'll have to 
adjust this property explicitly.
+     * In order for fast clean to work correctly, this directory must reside 
on the same mountpoint that the
+     * various directories that will be deleted.  This is usually the case 
when the whole code tree is setup to
+     * reside on a standard drive.

Review comment:
       Do you imply atomic move does not work on Windows ? I'm not sure what 
wording to use here... any suggestion welcomed !




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to