caiwei-ebay removed a comment on pull request #136:
URL: https://github.com/apache/maven-resolver/pull/136#issuecomment-987514827


   Basically the strategy of this approach is:
   - Skip more nodes
   - Reconcile least nodes
   
   There is one more case that the node can be skipped reconciling: the node's 
parents includes any conflict losers.
   In such case, maven won't pick up such node at all, so it is safe to skip 
reconciling.
   Also renamed a few variables, added a few comments to make it easy to 
understand.
   
   Here is the commit:
   
https://github.com/apache/maven-resolver/pull/136/commits/78e5e98b6430ba71c982cbc9bce6f603cc2cb286
   
   We have recertified this code changes by running large numbers of 
applications in our company by comparing dependency:tree and dependency:list 
result.
   
   Now most of the applications skipped quite a few nodes and just need to 
reconcile 0 nodes.
   And if there is version conflicts, this approach just needs to reconcile 
least nodes. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to