[
https://issues.apache.org/jira/browse/MNG-7377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17466635#comment-17466635
]
Jeff Hodges edited comment on MNG-7377 at 12/29/21, 11:07 PM:
--------------------------------------------------------------
Thanks again for looking at this.
I dropped a comment on the PR, but let me add words here, too, so folks don't
need to dig:
I made https://issues.apache.org/jira/browse/RAT-292 in response
It also turns out adding {{.vscode}} to {{.gitignore}} is the only change we
need to convince rat to not alarm. Adding to {{.gitignore}} also would make
sure reviewers aren't having to waste cycles ensuring that {{.vscode}} doesn't
get accidentally added to git, and avoids contributors having to make global
changes to their config to get a working build.
I've updated the PR to only touch .gitignore in case y'all are still interested
was (Author: jmhodges):
Thanks again for looking at this.
I dropped a comment on the PR, but let me add words here, too, so folks don't
need to dig:
I made https://issues.apache.org/jira/browse/RAT-292 in response
It also turns out adding {{.vscode}} to {{.gitignore}} turns out to be the only
change we need to convince rat to not alarm. Adding to {{.gitignore}} also
would make sure reviewers aren't having to waste cycles ensuring that
{{.vscode}} doesn't get accidentally added to git, and avoids contributors
having to make global changes to their config to get a working build.
I've updated the PR to only touch .gitignore in case y'all are still interested
> Reading code in vscode causes maven's Apache Rat config to alarm
> ----------------------------------------------------------------
>
> Key: MNG-7377
> URL: https://issues.apache.org/jira/browse/MNG-7377
> Project: Maven
> Issue Type: Bug
> Reporter: Jeff Hodges
> Priority: Major
>
> vscode adds a `.vscode` directory to the top of a git repo it's opened in.
> This is harmless, but the apache-rat plugin configured in the maven's
> top-level `pom.xml` sounds the alarm on it and doesn't even allow the code to
> compile. That means anyone reading maven's code in vscode will have a failing
> build
> I've got a patch I'll post that ignores the `.vscode` dir in the rat's config
> and in `.gitignore`.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
