michael-o commented on a change in pull request #58:
URL: https://github.com/apache/maven-plugin-tools/pull/58#discussion_r777694832
##########
File path:
maven-plugin-plugin/src/main/java/org/apache/maven/plugin/plugin/AbstractGeneratorMojo.java
##########
@@ -163,7 +164,36 @@
* @since 3.3
*/
@Parameter
- protected List<String> packagingTypes = Arrays.asList( "maven-plugin" );
+ protected List<String> packagingTypes = Collections.singletonList(
"maven-plugin" );
Review comment:
Yes, you are right. Let's keep your change. I have just noticed this and
it felt awkward.
##########
File path:
maven-plugin-plugin/src/main/java/org/apache/maven/plugin/plugin/AbstractGeneratorMojo.java
##########
@@ -185,8 +185,8 @@
private List<String> expectedProvidedScopeGroupIds =
Collections.singletonList( "org.apache.maven" );
/**
- * List of {@code G:A} strings of artifact coordinates that are to be
excluded from "expected provided scope" check.
- * Default value: {@code ["org.apache.maven:maven-archiver",
"org.apache.maven:maven-jxr"]}.
+ * List of {@code groupID:artifactID} strings of artifact coordinates that
are to be excluded from "expected
Review comment:
Well, the field above says `groupId`, not `groupID` and the former is
the term we use everywhere.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
