hboutemy commented on a change in pull request #650: URL: https://github.com/apache/maven/pull/650#discussion_r779209647
########## File path: maven-core/src/main/java/org/apache/maven/lifecycle/providers/AbstractLifecycleProvider.java ########## @@ -0,0 +1,64 @@ +package org.apache.maven.lifecycle.providers; + +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +import java.util.Arrays; +import java.util.Collections; +import java.util.HashMap; + +import javax.inject.Provider; + +import org.apache.maven.lifecycle.Lifecycle; +import org.apache.maven.lifecycle.mapping.LifecyclePhase; + +/** + * Base lifecycle provider. + */ +public abstract class AbstractLifecycleProvider + implements Provider<Lifecycle> +{ + private final Lifecycle lifecycle; + + protected AbstractLifecycleProvider( String id, String[] phases, String[] pluginBindings ) + { + HashMap<String, LifecyclePhase> defaultBindings = null; + if ( pluginBindings != null ) + { + int len = pluginBindings.length; + defaultBindings = new HashMap<>(); + for ( int i = 0; i < len; i++ ) + { + defaultBindings.put( pluginBindings[i++], new LifecyclePhase( pluginBindings[i] ) ); Review comment: instead of copy pasting much code for instantiating classes, everything is done in Abstract from String[] values provided by each providers, with good names of constants/parameters read the Providers and you will see how it's easier to read (and later update documentation https://maven.apache.org/ref/3.8.4/maven-core/lifecycles.html ) and one aspect to not under-estimate: classes (and their fields) in that area have such misleading names that it really adds obscurity (and I really mean *obscurity*). That's why I really value the reference documentation pages I wrote that put modern "normal user" terms to what these default lifecycle define I have a equivalent PR in preparation for default lifecycle per-packaging plugin bindings https://maven.apache.org/ref/3.8.4/maven-core/default-bindings.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
