gnodet commented on a change in pull request #621:
URL: https://github.com/apache/maven/pull/621#discussion_r779512984
##########
File path:
maven-core/src/main/java/org/apache/maven/lifecycle/internal/LifecycleModuleBuilder.java
##########
@@ -89,8 +89,12 @@ public void buildProject( MavenSession session, MavenSession
rootSession, Reacto
// session may be different from rootSession seeded in DefaultMaven
// explicitly seed the right session here to make sure it is used by
Guice
- sessionScope.enter( reactorContext.getSessionScopeMemento() );
- sessionScope.seed( MavenSession.class, session );
+ final boolean scoped = session != rootSession;
Review comment:
I think so, when sessions are cloned, they are supposed to refer to
different parts of the build, so I would not expect an equality check semantic
here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
