kwin commented on a change in pull request #4:
URL: https://github.com/apache/maven-verifier/pull/4#discussion_r779782517
##########
File path: src/main/java/org/apache/maven/it/Verifier.java
##########
@@ -103,23 +103,32 @@
private boolean debug;
+ /**
+ * If {@code true} uses {@link ForkedLauncher}, if {@code false} uses
{@link Embedded3xLauncher},
+ * otherwise considers the value {@link #forkMode}.
+ */
Review comment:
Sorry but I don't think that adding javadoc to existing/unmodified
fields/methods deserves a dedicated JIRA nor PR. This was mostly for me to
understand how the functionality works. I can remove it if you want, but I
won't dedicated time to recontribute that again in another PR.
##########
File path: src/main/java/org/apache/maven/it/Verifier.java
##########
@@ -103,23 +103,32 @@
private boolean debug;
+ /**
+ * If {@code true} uses {@link ForkedLauncher}, if {@code false} uses
{@link Embedded3xLauncher},
+ * otherwise considers the value {@link #forkMode}.
+ */
private Boolean forkJvm;
private String logFileName = LOG_FILENAME;
- private String defaultMavenHome;
-
- private String defaultClassworldConf;
-
- private String defaultClasspath;
+ private String mavenHome;
// will launch mvn with --debug
private boolean mavenDebug = false;
+ /**
+ * Either "auto" (use {@link ForkedLauncher} when {@link
#environmentVariables} is not empty,
+ * otherwise use {@link Embedded3xLauncher}) , "embedder" (always use
{@link Embedded3xLauncher})
+ * or something else (always use {@link ForkedLauncher}).
+ * Set through system property {@code verifier.forkMode}.
+ * Only relevant if {@link #forkJvm} is {@code null}.
+ */
Review comment:
Same as above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
