michael-o commented on a change in pull request #616:
URL: https://github.com/apache/maven/pull/616#discussion_r780390658
##########
File path:
maven-embedder/src/main/java/org/apache/maven/cli/internal/BootstrapCoreExtensionManager.java
##########
@@ -114,14 +119,38 @@ private CoreExtensionEntry createExtension( CoreExtension
extension, List<Artifa
{
String realmId =
"coreExtension>" + extension.getGroupId() + ":" +
extension.getArtifactId() + ":" + extension.getVersion();
- ClassRealm realm = classWorld.newRealm( realmId, null );
- log.debug( "Populating class realm " + realm.getId() );
- realm.setParentRealm( parentRealm );
+ ClassRealm realm;
+ Set<String> providedArtifacts = Collections.emptySet();
+ if ( "parent-first".equals( extension.getClassLoadingStrategy() ) )
+ {
+ realm = classWorld.newRealm( realmId, null );
+ realm.importFrom( parentRealm, "" );
+ }
+ else if ( "plugin".equals( extension.getClassLoadingStrategy() ) )
+ {
+ realm = classWorld.newRealm( realmId, null );
+ coreExports.getExportedPackages().forEach( ( p, cl ) ->
realm.importFrom( cl, p ) );
+ providedArtifacts = coreExports.getExportedArtifacts();
+ }
+ else
+ {
+ realm = classWorld.newRealm( realmId, null );
Review comment:
This `realm` appears three times, why not move up?
##########
File path:
maven-embedder/src/main/java/org/apache/maven/cli/internal/BootstrapCoreExtensionManager.java
##########
@@ -114,14 +119,38 @@ private CoreExtensionEntry createExtension( CoreExtension
extension, List<Artifa
{
String realmId =
"coreExtension>" + extension.getGroupId() + ":" +
extension.getArtifactId() + ":" + extension.getVersion();
- ClassRealm realm = classWorld.newRealm( realmId, null );
- log.debug( "Populating class realm " + realm.getId() );
- realm.setParentRealm( parentRealm );
+ ClassRealm realm;
+ Set<String> providedArtifacts = Collections.emptySet();
+ if ( "parent-first".equals( extension.getClassLoadingStrategy() ) )
+ {
+ realm = classWorld.newRealm( realmId, null );
+ realm.importFrom( parentRealm, "" );
+ }
+ else if ( "plugin".equals( extension.getClassLoadingStrategy() ) )
+ {
+ realm = classWorld.newRealm( realmId, null );
+ coreExports.getExportedPackages().forEach( ( p, cl ) ->
realm.importFrom( cl, p ) );
+ providedArtifacts = coreExports.getExportedArtifacts();
+ }
+ else
+ {
+ realm = classWorld.newRealm( realmId, null );
Review comment:
Obviously, this needs comment: `// self-first`?!
##########
File path:
maven-embedder/src/main/java/org/apache/maven/cli/internal/BootstrapCoreExtensionManager.java
##########
@@ -114,14 +119,38 @@ private CoreExtensionEntry createExtension( CoreExtension
extension, List<Artifa
{
String realmId =
"coreExtension>" + extension.getGroupId() + ":" +
extension.getArtifactId() + ":" + extension.getVersion();
- ClassRealm realm = classWorld.newRealm( realmId, null );
- log.debug( "Populating class realm " + realm.getId() );
- realm.setParentRealm( parentRealm );
+ ClassRealm realm;
+ Set<String> providedArtifacts = Collections.emptySet();
+ if ( "parent-first".equals( extension.getClassLoadingStrategy() ) )
Review comment:
Should it fail if the value is unknown? `classLoadingStrategy`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
