cstamas commented on a change in pull request #650:
URL: https://github.com/apache/maven/pull/650#discussion_r780109529
##########
File path:
maven-core/src/main/java/org/apache/maven/lifecycle/providers/CleanLifecycleProvider.java
##########
@@ -19,45 +19,33 @@
* under the License.
*/
-import java.util.Arrays;
-import java.util.Collections;
-import java.util.HashMap;
-
import javax.inject.Inject;
import javax.inject.Named;
-import javax.inject.Provider;
import javax.inject.Singleton;
-import org.apache.maven.lifecycle.Lifecycle;
-import org.apache.maven.lifecycle.mapping.LifecyclePhase;
-
+/**
+ * {@code clean} lifecycle provider.
+ */
@Named( "clean" )
Review comment:
shlould be `CleanLifecycleProvider.LIFECYCLE_ID`
##########
File path:
maven-core/src/main/java/org/apache/maven/lifecycle/providers/CleanLifecycleProvider.java
##########
@@ -19,45 +19,33 @@
* under the License.
*/
-import java.util.Arrays;
-import java.util.Collections;
-import java.util.HashMap;
-
import javax.inject.Inject;
import javax.inject.Named;
-import javax.inject.Provider;
import javax.inject.Singleton;
-import org.apache.maven.lifecycle.Lifecycle;
-import org.apache.maven.lifecycle.mapping.LifecyclePhase;
-
+/**
+ * {@code clean} lifecycle provider.
+ */
@Named( "clean" )
Review comment:
Same for other 2
##########
File path:
maven-core/src/main/java/org/apache/maven/lifecycle/providers/AbstractLifecycleProvider.java
##########
@@ -0,0 +1,71 @@
+package org.apache.maven.lifecycle.providers;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import java.util.Arrays;
+import java.util.Collections;
+import java.util.HashMap;
+
+import javax.inject.Provider;
+
+import org.apache.maven.lifecycle.Lifecycle;
+import org.apache.maven.lifecycle.mapping.LifecyclePhase;
+
+/**
+ * Base lifecycle provider.
+ */
+public abstract class AbstractLifecycleProvider
+ implements Provider<Lifecycle>
+{
+ private final Lifecycle lifecycle;
+
+ protected AbstractLifecycleProvider( String id, String[] phases, String[]
pluginBindings )
+ {
+ HashMap<String, LifecyclePhase> defaultBindings = null;
+ if ( pluginBindings != null )
+ {
+ final int len = pluginBindings.length;
+
+ if ( len < 1 || len % 2 != 0 )
Review comment:
make it `len < 2`
##########
File path:
maven-core/src/main/java/org/apache/maven/lifecycle/providers/CleanLifecycleProvider.java
##########
@@ -19,45 +19,33 @@
* under the License.
*/
-import java.util.Arrays;
-import java.util.Collections;
-import java.util.HashMap;
-
import javax.inject.Inject;
import javax.inject.Named;
-import javax.inject.Provider;
import javax.inject.Singleton;
-import org.apache.maven.lifecycle.Lifecycle;
-import org.apache.maven.lifecycle.mapping.LifecyclePhase;
-
+/**
+ * {@code clean} lifecycle provider.
+ */
@Named( "clean" )
@Singleton
public final class CleanLifecycleProvider
- implements Provider<Lifecycle>
+ extends AbstractLifecycleProvider
{
- private final Lifecycle lifecycle;
+ private static final String LIFECYCLE_ID = "clean";
- @Inject
- public CleanLifecycleProvider()
- {
- HashMap<String, LifecyclePhase> phases = new HashMap<>();
- phases.put( "clean", new LifecyclePhase(
"org.apache.maven.plugins:maven-clean-plugin:3.1.0:clean" ) );
-
- this.lifecycle = new Lifecycle(
+ private static final String[] PHASES = {
+ "pre-clean",
"clean",
- Collections.unmodifiableList( Arrays.asList(
- "pre-clean",
- "clean",
- "post-clean"
- ) ),
- Collections.unmodifiableMap( phases )
- );
- }
-
- @Override
- public Lifecycle get()
- {
- return lifecycle;
- }
+ "post-clean"
+ };
+
+ private static final String[] BINDINGS = {
+ "clean", "org.apache.maven.plugins:maven-clean-plugin:3.1.0:clean"
+ };
+
+ @Inject
+ public CleanLifecycleProvider()
+ {
Review comment:
Is explicit IMHO, also does not stirs anything (present or not present),
so IMHO is okay.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
