Tibor17 commented on pull request #428: URL: https://github.com/apache/maven-surefire/pull/428#issuecomment-1008034228
@slawekjaranowski I have the first question regarding the following POM section in the [commit](https://github.com/apache/maven-surefire/pull/428/commits/a6f0bebe66f088075083a9f7e5dd4c8965c6d88e). ``` <execution> <id>show-test-classpath</id> <phase>generate-sources</phase> <goals> <goal>build-classpath</goal> </goals> <configuration> <includeScope>test</includeScope> </configuration> </execution> ``` How it is related to JSR 305? Did the build fail with this upgrade? You make it for better visibility of the CP in the logs? The `try-catch` and `printStackTrace` is the same case? The `toURI().toURL()` or the old class `URL` is a typical warning in IDE. It is a cosmetic change. We can keep it in this PR, I don't mind, but the changes should go to one commit, and the log visibility changes in another commit. And then it would be clear what purpose you have with it and also the history in the Git would be more clear to everybody. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
