slawekjaranowski commented on a change in pull request #94:
URL: https://github.com/apache/maven-shared-utils/pull/94#discussion_r781991978
##########
File path: src/main/java/org/apache/maven/shared/utils/cli/Commandline.java
##########
@@ -65,12 +65,14 @@
public class Commandline
implements Cloneable
{
- private final List<Arg> arguments = new Vector<Arg>();
+ private final List<Arg> arguments = new Vector<>();
Review comment:
Exactly.
I don't want to mixing changes in one PR.
Probably Vector and below `synchronizedMap` can be replaced for not
synchronized collections.
`Commandline` should be one time instance not shared by threads.
But it is another issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
