ppalaga commented on a change in pull request #580:
URL: https://github.com/apache/maven-mvnd/pull/580#discussion_r782238545
##########
File path: client/src/main/java/org/mvndaemon/mvnd/client/DefaultClient.java
##########
@@ -114,6 +115,12 @@ public static void main(String[] argv) throws Exception {
System.setProperty(Environment.MVND_HOME.getProperty(),
parameters.mvndHome().toString());
+ // .mvn/jvm.config
+ if (Files.isRegularFile(parameters.jvmConfigPath())) {
+ String jvmArgs =
Files.lines(parameters.jvmConfigPath()).collect(Collectors.joining(" "));
+ parameters = parameters.withJvmArgs(" " + jvmArgs);
Review comment:
> we can't validate all JVM options...
Yes, any code to improve the UX might get complex, hard to maintain and
still not covering 100% of cases.
Maybe we should at least mention this combination issue (and the order of
precedence) in the help entries of `mvnd.jvmArgs`, `mvnd.maxHeapSize` and add a
help entry about `jvm.config`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
