famod commented on a change in pull request #662:
URL: https://github.com/apache/maven/pull/662#discussion_r785508393
##########
File path:
maven-core/src/main/java/org/apache/maven/lifecycle/internal/builder/multithreaded/MultiThreadedBuilder.java
##########
@@ -129,14 +132,23 @@ private void multiThreadedProjectTaskSegmentBuild(
ConcurrencyDependencyGraph an
Map<MavenProject,
ProjectSegment> projectBuildList,
ThreadOutputMuxer muxer
)
{
+ // gather artifactIds which are not unique so that the respective
thread names can be extended with the groupId
+ Set<String> duplicateArtifactIds = projectBuildList.keySet().stream()
Review comment:
> 1. I wonder how much calculation overhead this poses to the execution
Even for hunderts of projects this should be alright, IMO, but I haven't
done any measurements.
We could also switch over to something like:
https://stackoverflow.com/a/30741906/9529981
> 2. This won't work for 3.8.x because of Java 8 features.
Right. I can create a Java 8 compatible backport PR if you want.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
