eolivelli commented on a change in pull request #443:
URL: https://github.com/apache/maven-surefire/pull/443#discussion_r786163443
##########
File path: maven-failsafe-plugin/pom.xml
##########
@@ -266,12 +266,12 @@
<postBuildHookScript>verify</postBuildHookScript>
<settingsFile>src/it/settings.xml</settingsFile>
<skipInvocation>${skipTests}</skipInvocation>
- <streamLogs>true</streamLogs>
<showErrors>true</showErrors>
<properties>
<integration-test-port>${failsafe-integration-test-port}</integration-test-port>
<integration-test-stop-port>${failsafe-integration-test-stop-port}</integration-test-stop-port>
</properties>
+ <debug>true</debug>
Review comment:
is this needed ?
##########
File path: surefire-booter/pom.xml
##########
@@ -115,11 +115,12 @@
</plugin>
<plugin>
<artifactId>maven-surefire-plugin</artifactId>
+ <version>3.0.0-M3</version>
Review comment:
why are we using this older version "3.0.0-M3" ? what's the reasoning
about choosing this one ? could it be 2.x ?
##########
File path: surefire-shared-utils/pom.xml
##########
@@ -100,5 +102,35 @@
</plugin>
</plugins>
</build>
-
+ <profiles>
+ <profile>
+ <!-- First, install the project without tests -> mvn install
-DskipTests
+ This is a workaround for IntelliJ IDEA, see
https://youtrack.jetbrains.com/issue/IDEA-148573
+ IDEA is able to recognize external artifacts with classifiers. But
IDEA expects modules and their artifacts
+ without classifier. If the version differs from project, the idea
would understand it as external artifact.
+ -->
+ <id>ide-development</id>
+ <build>
+ <plugins>
+ <plugin>
+ <artifactId>maven-install-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>install-devel-jar</id>
+ <phase>install</phase>
+ <goals>
+ <goal>install-file</goal>
+ </goals>
+ <configuration>
+
<artifactId>surefire-shared-utils</artifactId>
+ <version>3-SNAPSHOT</version>
Review comment:
why 3-SNAPSHOT ? is this a random name ?
##########
File path: maven-failsafe-plugin/pom.xml
##########
@@ -266,12 +266,12 @@
<postBuildHookScript>verify</postBuildHookScript>
<settingsFile>src/it/settings.xml</settingsFile>
<skipInvocation>${skipTests}</skipInvocation>
- <streamLogs>true</streamLogs>
Review comment:
why are we changing this line ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
