ibabiankou commented on a change in pull request #144:
URL: https://github.com/apache/maven-resolver/pull/144#discussion_r788205320
##########
File path:
maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/collect/DefaultDependencyCollector.java
##########
@@ -343,36 +358,75 @@ private static String getId( Artifact a )
return a.getGroupId() + ':' + a.getArtifactId() + ':' +
a.getClassifier() + ':' + a.getExtension();
}
+ private void processNode( Args args, Results results, DependencyNode
current )
+ {
+ DataPool.DependencyNodeTraceContext traceContext =
args.pool.getTraceContext( current );
+ if ( traceContext == null || !traceContext.recursive )
+ {
+ return;
+ }
+
+ DependencySelector selector = traceContext.depSelector;
+ DependencyManager manager = traceContext.depManager;
+ DependencyTraverser traverser = traceContext.depTraverser;
+ VersionFilter filter = traceContext.verFilter;
+
+ if ( traceContext.isRoot )
+ {
+ //Should not cache the children of root node just like original
DFS solution
Review comment:
I moved the caching logic back to the place where it used to be, it
makes smaller diff and simplifies the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
