[
https://issues.apache.org/jira/browse/MBUILDCACHE-13?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17479399#comment-17479399
]
ASF GitHub Bot commented on MBUILDCACHE-13:
-------------------------------------------
AlexanderAshitkin commented on a change in pull request #2:
URL:
https://github.com/apache/maven-build-cache-extension/pull/2#discussion_r788804500
##########
File path: src/main/java/org/apache/maven/buildcache/CacheControllerImpl.java
##########
@@ -737,7 +737,7 @@ public boolean isForcedExecution( MavenProject project,
MojoExecution execution
{
return true;
}
- String alwaysRunPlugins = project.getProperties().getProperty(
"remote.cache.alwaysRunPlugins" );
+ String alwaysRunPlugins = project.getProperties().getProperty(
"maven.build.cache.alwaysRunPlugins" );
Review comment:
please extract to constant and add annotation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
> rename remote.cache.* properties to build.cache.*
> -------------------------------------------------
>
> Key: MBUILDCACHE-13
> URL: https://issues.apache.org/jira/browse/MBUILDCACHE-13
> Project: Maven Build Cache Extension
> Issue Type: Task
> Reporter: Herve Boutemy
> Priority: Major
> Labels: pull-request-available
>
> current parameters are named "remote.cache.*":
> https://maven.apache.org/extensions/maven-build-cache-extension/parameters.html
> is it really restricted to remote build cache? Or just historical naming done
> before we chose "build cache" as the keyword (instead of unclear "cache")
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
