[
https://issues.apache.org/jira/browse/MWRAPPER-47?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17480745#comment-17480745
]
ASF GitHub Bot commented on MWRAPPER-47:
----------------------------------------
jimisola commented on pull request #14:
URL: https://github.com/apache/maven-wrapper/pull/14#issuecomment-1019581805
I agree. I've renamed DOWNLOAD_URL to WRAPPER_URL in mvnw.cmd. Although, it
was a simple find-replace it has not been tested since I don't use Windows.
Not sure what choices you are referring to (command line option?), but that
will be clearer with another Jira issue :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
> Use name wrapperUrl consistently in Maven Wrapper files/scripts
> ---------------------------------------------------------------
>
> Key: MWRAPPER-47
> URL: https://issues.apache.org/jira/browse/MWRAPPER-47
> Project: Maven Wrapper
> Issue Type: Improvement
> Components: Maven Wrapper Scripts
> Affects Versions: 3.1.0
> Reporter: Jimisola Laursen
> Priority: Low
> Labels: up-for-grabs
> Fix For: 3.1.1
>
>
> maven-wrapper.properties has two properties: *wrapperUrl* and distributionUrl
> However, in the mvnw script the wrapperUrl is stored as jarUrl (no need for
> confusion) and after download it is referred to as wrapperJarPath.
> Rename jarUrl to wrapperUrl in mvn[.cmd] for consistency.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
