[
https://issues.apache.org/jira/browse/MSHARED-1029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17481589#comment-17481589
]
ASF GitHub Bot commented on MSHARED-1029:
-----------------------------------------
cstamas commented on a change in pull request #8:
URL: https://github.com/apache/maven-reporting-exec/pull/8#discussion_r791408768
##########
File path: pom.xml
##########
@@ -170,7 +145,13 @@
<dependency>
<groupId>junit</groupId>
<artifactId>junit</artifactId>
- <version>4.13.1</version>
+ <version>4.13.2</version>
+ <scope>test</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.slf4j</groupId>
+ <artifactId>slf4j-simple</artifactId>
+ <version>1.7.32</version>
Review comment:
These are all "test" scoped deps, so they matter "locally" only, so IMHO
does not matter. We can align them (by same logic as resolver, so "use version
maven X used"), but putting them into parent is overkill IMO.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
> Update plugin (requires Maven 3.2.5+)
> -------------------------------------
>
> Key: MSHARED-1029
> URL: https://issues.apache.org/jira/browse/MSHARED-1029
> Project: Maven Shared Components
> Issue Type: Task
> Components: maven-reporting-exec
> Reporter: Tamás Cservenák
> Priority: Major
>
> Drop Maven 3.1 and 3.0 support (to get rid of Sonatype Aether), align with
> other components.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
