caiwei-ebay commented on pull request #144: URL: https://github.com/apache/maven-resolver/pull/144#issuecomment-1023824789
> @michael-o Guys, can you verbally express what you change actually does? A: This PR is pure BFS approach. Just a change from DFS -> BFS for future PRs related MRESOLVER-133, MRESOLVER-228 and MRESOLVER-7. With DFS, maven resolves all nodes to compute the dependency tree. With this BFS solution, it still resolves all nodes to compute the dependency tree. Later, I would like to submit a PR to skip certain nodes resolving to improve performance. Does it incur any resolution result changes? If not, can this be tested some how? A: Nope, it won't introduce any resolution result changes. No tests broken. Regarding the test, I have dryrun large number of apps in our company by comparing dependency tree and dependency list, no issues found. Not sure if this is the right test method your are expecting. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
