cstamas commented on a change in pull request #141:
URL: https://github.com/apache/maven-resolver/pull/141#discussion_r795065476
##########
File path:
maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/AbstractChecksumPolicy.java
##########
@@ -41,26 +41,26 @@ protected AbstractChecksumPolicy( TransferResource resource
)
}
@Override
- public boolean onChecksumMatch( String algorithm, int kind )
+ public boolean onChecksumMatch( String algorithm, ChecksumKind kind )
{
requireNonNull( algorithm, "algorithm cannot be null" );
return true;
}
@Override
- public void onChecksumMismatch( String algorithm, int kind,
ChecksumFailureException exception )
+ public void onChecksumMismatch( String algorithm, ChecksumKind kind,
ChecksumFailureException exception )
throws ChecksumFailureException
{
requireNonNull( algorithm, "algorithm cannot be null" );
requireNonNull( exception, "exception cannot be null" );
- if ( ( kind & KIND_UNOFFICIAL ) == 0 )
+ if ( ChecksumKind.REMOTE == kind )
Review comment:
`( kind & KIND_UNOFFICIAL ) == 0` is official, no (result is zero).
"Official" now is explicit.
##########
File path:
maven-resolver-impl/src/main/java/org/eclipse/aether/impl/guice/AetherModule.java
##########
@@ -207,6 +212,17 @@ protected void configure()
}
+ @Provides
+ @Singleton
+ Map<String, ProvidedChecksumsSource> provideDownloadChecksumSources(
Review comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
