sman-81 commented on a change in pull request #453:
URL: https://github.com/apache/maven-surefire/pull/453#discussion_r795094164
##########
File path: surefire-grouper/pom.xml
##########
@@ -32,18 +32,53 @@
<name>Maven Surefire Test-Grouping Support</name>
<description>Maven Surefire Test-Grouping Support</description>
+ <properties>
+ <javacc.version>7.0.10</javacc.version>
+
<generated.sources.dir>${project.basedir}/src/generated/java</generated.sources.dir>
+ </properties>
+
<build>
<plugins>
<plugin>
- <groupId>org.codehaus.mojo</groupId>
+ <groupId>org.javacc.plugin</groupId>
<artifactId>javacc-maven-plugin</artifactId>
- <version>2.6</version>
+ <version>3.0.3</version>
<executions>
<execution>
<id>javacc</id>
<goals>
<goal>javacc</goal>
</goals>
+ <configuration>
+
<sourceDirectory>${project.basedir}/src/main/javacc</sourceDirectory>
Review comment:
> The `src/main` files are a subject to git commit them. So I disagree
to touch this folder.
@Tibor17
Did you notice `.gitignore` was updated to prevent this?
Take a look at my comment in the Jira-Ticket.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
