cstamas edited a comment on pull request #100: URL: https://github.com/apache/maven-release/pull/100#issuecomment-1025186600
> AFAIK, many maven-plugin-plugin releases were done until now using maven-release-plugin, so I don't see what you are trying to "fix" Wrong. Let me fix your statement: "many maven-plugin-plugin releases were done until now using maven-release-plugin **thanks to workarounds and hacks**". And this stands not only for m-p-p but for others as well like m-surefire-p. The signs that "something is wrong": * https://github.com/apache/maven-plugin-tools/blob/master/maven-plugin-plugin/pom.xml#L274 * https://github.com/apache/maven-plugin-tools/blob/master/maven-plugin-plugin/pom.xml#L299 * https://github.com/apache/maven-surefire/blob/master/maven-surefire-plugin/pom.xml#L94 and so on... I hope we both agree that in case of 2 (or more) plugins refs for same version is "best practice" to define the plugin version as property? And it is the m-resolver-p (according to all these "comments" above) that prevents it, hence, it forces you to work AGAINST best practice, that IMHO is worth fixing. Or in short, your statement is correct due all these sprinkled workarounds (devs forced to abandon best practices and leaving notes in POMs for future). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
