michael-o commented on pull request #148: URL: https://github.com/apache/maven-resolver/pull/148#issuecomment-1025703182
> > Any reason not to pass the actual enum? Kind can never be null, can it? > > For start, exception is in resolver-api, while enum is on ChecksumPolicy (resolver-spi), we would need to move it, but am fine with it. Kind never can be null (on checksum validator side), as "expected" must come from somewhere, yes. So should we move ChecksumKind out to resolver-api? On the move: Does it any benefit moving to Resolver API? If not, I can live with the `toString()` repr. Illegal values cannot be passed and are never `null` because we control the enum. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
