gnodet edited a comment on pull request #92: URL: https://github.com/apache/maven-doxia/pull/92#issuecomment-1028852684
> Wow, this is insane! I remember that `@Inject` has a slightly different notion comparented to `@Requirement`. Does it matter here or can we replace it 1:1? Not much difference afaik. The `role` is mapped to the class name (and usually not of any use) and the `hint` is covered by the `@Name` annotation. There's not real use case for it when injecting, because the concrete class is usually injected, for example in https://github.com/apache/maven-doxia/pull/92/files#diff-04c5c280b39239f19337818da8190fb25ce92c6e59d075520163f8e59351fac2L45, so guice has no real choice. If we were injecting the `Parser` class, we'd have to specify `@Inject @Named( "fml" )` for example. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
