michael-o commented on a change in pull request #661:
URL: https://github.com/apache/maven/pull/661#discussion_r801526860
##########
File path:
maven-core/src/test/java/org/apache/maven/lifecycle/internal/stub/MojoExecutorStub.java
##########
@@ -47,24 +48,23 @@ public MojoExecutorStub(
BuildPluginManager pluginManager,
MavenPluginManager mavenPluginManager,
LifecycleDependencyResolver lifeCycleDependencyResolver,
- ExecutionEventCatapult eventCatapult )
+ ExecutionEventCatapult eventCatapult,
+ MojosExecutionStrategy mojosExecutionStrategy )
{
- super( pluginManager, mavenPluginManager, lifeCycleDependencyResolver,
eventCatapult );
+ super( pluginManager, mavenPluginManager, lifeCycleDependencyResolver,
eventCatapult, mojosExecutionStrategy );
}
@Override
- public void execute( MavenSession session, MojoExecution mojoExecution,
ProjectIndex projectIndex,
- DependencyContext dependencyContext, PhaseRecorder
phaseRecorder )
+ public void execute( MavenSession session, List<MojoExecution>
mojoExecutions, ProjectIndex projectIndex )
throws LifecycleExecutionException
{
- executions.add( mojoExecution );
+ executions.addAll( mojoExecutions );
}
@Override
- public void execute( MavenSession session, List<MojoExecution>
mojoExecutions, ProjectIndex projectIndex )
- throws LifecycleExecutionException
+ public List<MavenProject> executeForkedExecutions( MojoExecution
mojoExecution, MavenSession session, ProjectIndex projectIndex ) throws
LifecycleExecutionException
{
- executions.addAll(mojoExecutions);
+ return null;
Review comment:
Can you please explain those two changes. Why is the first one now
`addAll` and the second one `null`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
