[ 
https://issues.apache.org/jira/browse/MDEP-753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17491719#comment-17491719
 ] 

Henning Schmiedehausen commented on MDEP-753:
---------------------------------------------

The current 3.3.0-SNAPSHOT has some serious regressions/problem. It is not fit 
to be released. Here is a very obvious one (and easy to reproduce):

{code}
% git clone g...@github.com:jdbi/jdbi.git
% cd jdbi
% git checkout -b test v3.27.1
% mvn -DskipTests clean install -pl :jdbi3-spring5
{code}

This builds fine. It uses the 3.1.2 dependency plugin; the last one that 
actually works.

with the current 3.3.0-SNAPSHOT (and the 1.12.0 dependency analyzer library):

{code}
% mvn -DskipTests clean install -pl :jdbi3-spring5 
-Ddep.plugin.dependency.version=3.3.0-SNAPSHOT 
-Ddep.dependency-analyzer.version=1.12.0
[...]
[WARNING] Non-test scoped test only dependencies found:
[WARNING]    org.springframework:spring-core:jar:5.3.12:compile
{code}

Clearly, there are spring-core dependencies all over this project. Putting this 
dependency into test scope fails the build with compile errors.

I feel all of the post-3.1.2 work (and post 1.11.1 dependency analyzer) needs 
to be revisited. There are a number of very serious regressions that have not 
been addressed for a very long time.

> Non-test dependency reported as Non-test scoped test only dependency
> --------------------------------------------------------------------
>
>                 Key: MDEP-753
>                 URL: https://issues.apache.org/jira/browse/MDEP-753
>             Project: Maven Dependency Plugin
>          Issue Type: Bug
>          Components: analyze
>    Affects Versions: 3.2.0
>            Reporter: Elliotte Rusty Harold
>            Assignee: Elliotte Rusty Harold
>            Priority: Critical
>             Fix For: 3.3.0
>
>         Attachments: chas.zip, tj.zip
>
>
> Saw this when updating the google-http-java-client from 3.1.2 to 3.2.0 of the 
> plugin. I'm not immediately sure whether this is a regression:
> [INFO] --- maven-dependency-plugin:3.2.0:analyze (default-cli) @ 
> google-http-client ---
> Warning:  Non-test scoped test only dependencies found:
> Warning:     com.google.guava:guava:jar:30.1.1-android:compile
> Warning:     io.opencensus:opencensus-api:jar:0.28.0:compile
> Changing Guava to scope test breaks the build, which is expected based on the 
> code. The warning seems incorrect. 
> https://github.com/googleapis/google-http-java-client/pull/1396
> https://github.com/googleapis/google-http-java-client/pull/1396/checks?check_run_id=2809438131



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to