Tibor17 commented on a change in pull request #469:
URL: https://github.com/apache/maven-surefire/pull/469#discussion_r805568101
##########
File path:
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/TestSetRunListener.java
##########
@@ -51,13 +50,13 @@
* @author Kristian Rosenvold
*/
public class TestSetRunListener
- implements RunListener, ConsoleOutputReceiver, ConsoleLogger
+ implements TestRunListener, ConsoleLogger
Review comment:
@slawekjaranowski
This line of code `logger = (ConsoleLogger)
forkingReporterFactory.createReporter();` does not exist in the second commit.
The line is `logger = forkingReporterFactory.createTestReportListener();`.
Regarding the `ConsoleLoggerDecorator`, the decorator is used in the
InPlugin execution, not in fork. See the
`CommonReflector#createConsoleLogger()`. Then see `Object factory =
surefireReflector.createReportingReporterFactory( startupReportConfig,
consoleLogger );` in the class `InPluginVMSurefireStarter`. The decorator is
used in `ForkStarter#getSuitesIterator()` as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
