elharo commented on a change in pull request #196:
URL: 
https://github.com/apache/maven-dependency-plugin/pull/196#discussion_r806759679



##########
File path: 
src/site/apt/examples/exclude-dependencies-from-dependency-analysis.apt.vm
##########
@@ -34,10 +34,11 @@ Exclude dependencies from dependency analysis
   that contain annotations and the byte code analysis is unable to
   determine whether a jar is actually required or not.
 
-  The plugin can then be configured to ignore these dependencies in
-  either "declared but unused" or "undeclared but used" case or in
-  both simultaneously.  See the following POM configuration for an
-  example:
+  The plugin can then be configured to ignore dependencies in

Review comment:
       in --> that are

##########
File path: 
src/site/apt/examples/exclude-dependencies-from-dependency-analysis.apt.vm
##########
@@ -57,7 +58,7 @@ Exclude dependencies from dependency analysis
             <configuration>
               <failOnWarning>true</failOnWarning>
 
-              <!-- ignore jsr305 for both "used but undeclared" and "declared 
but unused" -->
+              <!-- ignore jsr305 for "used but undeclared", "declared but 
unused" and "non-test scoped" -->

Review comment:
       comma after unused"

##########
File path: 
src/site/apt/examples/exclude-dependencies-from-dependency-analysis.apt.vm
##########
@@ -34,10 +34,11 @@ Exclude dependencies from dependency analysis
   that contain annotations and the byte code analysis is unable to
   determine whether a jar is actually required or not.
 
-  The plugin can then be configured to ignore these dependencies in
-  either "declared but unused" or "undeclared but used" case or in
-  both simultaneously.  See the following POM configuration for an
-  example:
+  The plugin can then be configured to ignore dependencies in
+  "declared but unused", "undeclared but used" and "non-test scoped"

Review comment:
       comma after used"

##########
File path: 
src/main/java/org/apache/maven/plugins/dependency/analyze/AbstractAnalyzeMojo.java
##########
@@ -167,7 +169,7 @@
 
     /**
      * List of dependencies that will be ignored. Any dependency on this list 
will be excluded from the "declared but
-     * unused" and the "used but undeclared" list. The filter syntax is:
+     * unused", the "used but undeclared" and the "non-test scoped" list. The 
filter syntax is:

Review comment:
       comma after undeclared"




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to