slawekjaranowski commented on a change in pull request #50:
URL:
https://github.com/apache/maven-dependency-analyzer/pull/50#discussion_r808458152
##########
File path: pom.xml
##########
@@ -192,24 +149,34 @@
<profiles>
<profile>
- <id>maven-repo-local</id>
- <activation>
- <property>
- <name>maven.repo.local</name>
- </property>
- </activation>
+ <id>run-its</id>
<build>
<plugins>
- <plugin>
- <artifactId>maven-surefire-plugin</artifactId>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-invoker-plugin</artifactId>
+ <executions>
+ <execution>
+ <goals>
+ <goal>install</goal>
+ <goal>integration-test</goal>
+ <goal>verify</goal>
+ </goals>
+ </execution>
+ </executions>
<configuration>
- <systemProperties combine.children="append">
- <property>
- <!-- Pass this through to the tests (if set!) to have them
pick the right repository -->
- <name>maven.repo.local</name>
- <value>${maven.repo.local}</value>
- </property>
- </systemProperties>
+ <cloneProjectsTo>${project.build.directory}/it</cloneProjectsTo>
+ <localRepositoryPath>target/local-repo</localRepositoryPath>
+ <settingsFile>src/it/settings.xml</settingsFile>
+ <postBuildHookScript>verify</postBuildHookScript>
+ <goals>
+ <goal>verify</goal>
+ </goals>
+ <properties>
+
<maven.compiler.source>${java.specification.version}</maven.compiler.source>
+
<maven.compiler.target>${java.specification.version}</maven.compiler.target>
Review comment:
Many thing depends on bytecode version in analysis so compiling test
code for many version can help detect future problem with ... next java version
if we need test feature which depends of jdk version we can add such
requrement in invoker.properties
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
