arturobernalg commented on a change in pull request #679:
URL: https://github.com/apache/maven/pull/679#discussion_r810587524
##########
File path: maven-embedder/src/main/java/org/apache/maven/cli/CleanArgument.java
##########
@@ -56,30 +56,12 @@
{
String cleanArgPart = arg.substring( 0, arg.length() - 1 );
- // if we're building an argument, keep doing so.
- if ( currentArg != null )
Review comment:
for the previous conditions. When it reach that line always would't
different of null.
` if ( arg.startsWith( "\"" ) )` the the are object is created `
currentArg = new StringBuilder( arg.substring( 1 ) );`
otherwise will never reach the next conditions
` if ( addedToBuffer && arg.endsWith( "\"" ) )`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]