slawekjaranowski commented on a change in pull request #474:
URL: https://github.com/apache/maven-surefire/pull/474#discussion_r813607241
##########
File path:
surefire-its/src/test/java/org/apache/maven/surefire/its/jiras/Surefire1787JUnit5IT.java
##########
@@ -109,14 +115,18 @@ public void testNgWithJupiterEngine()
.executeTest()
.verifyErrorFree( 2 )
.verifyTextInLog( "Running pkg.JUnit5Test" )
- .verifyTextInLog( "Running pkg.TestNGTest" );
+ .verifyTextInLog( "Running pkg.TestNGTest" )
+ .verifyTextInLog(
+ "Using auto detected provider
org.apache.maven.surefire.junitplatform.JUnitPlatformProvider" );
}
@Test
public void junit4Runner()
{
unpack( "junit5-runner" )
.executeTest()
- .verifyErrorFreeLog();
+ .verifyErrorFree( 1 )
+ .verifyTextInLog( "Running pkg.JUnit5Tests" )
+ .verifyTextInLog( "Using auto detected provider
org.apache.maven.surefire.junit4.JUnit4Provider" );
Review comment:
It is ok IMHO. When we want Junit5 test using Junit4 we add
junit-platform-runner as a dependency.
https://junit.org/junit5/docs/current/user-guide/#running-tests-junit-platform-runner
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
