[
https://issues.apache.org/jira/browse/SUREFIRE-1681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17498519#comment-17498519
]
Olivier Lamy edited comment on SUREFIRE-1681 at 2/27/22, 1:22 AM:
------------------------------------------------------------------
[~tibordigana] please look my answer here
https://issues.apache.org/jira/browse/SUREFIRE-1426?focusedCommentId=17498518&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17498518
no need to duplicate conversation
and by the way please read the description which says
{quote}Surefire should only ignore test failures when
SurefirePlugin.testFailureIgnore property is set to true (as the name
suggests). Test errors should not be ignored.
If the forked JVM crashes during the test, then TEST-*.xml report file is not
created, so the user will miss the problem when he evaluates test reports
afterward (e.g. in Jenkins).
{quote}
this definitely apply to my concern. There is nothing related to asf build,
jpms build on jdk8.
I'm pretty sure I understand the fact jpms cannot work with jdk 1,8
was (Author: olamy):
[~tibordigana] please look my answer here
https://issues.apache.org/jira/browse/SUREFIRE-1426?focusedCommentId=17498518&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17498518
no need to duplicate conversation
> Don't ignore errors while using maven.test.failure.ignore
> ---------------------------------------------------------
>
> Key: SUREFIRE-1681
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1681
> Project: Maven Surefire
> Issue Type: New Feature
> Components: Maven Surefire Plugin
> Affects Versions: 3.0.0-M3
> Reporter: Josef Cacek
> Assignee: Tibor Digana
> Priority: Minor
> Time Spent: 20m
> Remaining Estimate: 0h
>
> This is a follow up for SUREFIRE-1426.
> Surefire should only ignore test failures when
> SurefirePlugin.testFailureIgnore property is set to true (as the name
> suggests). Test errors should not be ignored.
> If the forked JVM crashes during the test, then TEST-*.xml report file is not
> created, so the user will miss the problem when he evaluates test reports
> afterward (e.g. in Jenkins).
> The code of SurefireHelper.report execution could be improved to verify the
> error count:
> {code:java}
> if ( reportParameters.isTestFailureIgnore() && result.getErrors() == 0 )
> {
> log.error( createErrorMessage( reportParameters, result,
> firstForkException ) );
> }
> {code}
> instead of simply ignoring all problems as it's now:
> {code:java}
> if ( reportParameters.isTestFailureIgnore() )
> {
> log.error( createErrorMessage( reportParameters, result,
> firstForkException ) );
> }
> {code}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
