[ 
https://issues.apache.org/jira/browse/MSHARED-1041?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Slawomir Jaranowski updated MSHARED-1041:
-----------------------------------------
    Description: 
We can replace methods like:
{code:java}
public InvocationRequest setDebug( boolean debug )
{
      this.debug = debug;
      return this;
}
{code}
by
{code:java}
public InvocationRequest setDebug( boolean debug )
{
      if ( debug )
      {
        addArg( "-X" );
      }
      return this;
} 
{code}
and simplify {{MavenCommandLineBuilder}}

  was:
We can replace methods like:

{code}
public InvocationRequest setDebug( boolean debug )
{
      this.debug = debug;
      return this;
}
{code}

by

{code}
public InvocationRequest setDebug( boolean debug )
{
      addArg( "-X" );
      return this;
} 
{code}

and simplify {{MavenCommandLineBuilder}}


> Refactor: remove duplicate code, use addArg internally
> ------------------------------------------------------
>
>                 Key: MSHARED-1041
>                 URL: https://issues.apache.org/jira/browse/MSHARED-1041
>             Project: Maven Shared Components
>          Issue Type: Task
>          Components: maven-invoker
>            Reporter: Slawomir Jaranowski
>            Priority: Major
>
> We can replace methods like:
> {code:java}
> public InvocationRequest setDebug( boolean debug )
> {
>       this.debug = debug;
>       return this;
> }
> {code}
> by
> {code:java}
> public InvocationRequest setDebug( boolean debug )
> {
>       if ( debug )
>       {
>         addArg( "-X" );
>       }
>       return this;
> } 
> {code}
> and simplify {{MavenCommandLineBuilder}}



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to